-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental flag to transpile styled-components to next-yak #113
Comments
At the moment we don't support 100% of all features that |
Hi ! That's what I'm looking for. Transforming all these lines is a bit of work, before being convinced of the interest of this lib.
The other task I see for my codebase is to transform the |
I guess there are tools that help build scripts that transform js/ts files to handle these migrations, but I don't know this field. |
The migration is quite heavier than I thought. Multiple days of work for my map application. cartesapp/cartes#704 Running the build fails with an error that is not easy to understand.
|
I have never seen this error but i'll take a look - thanks for sharing |
could you please share which file is causing this? we noticed doing migration that styled component silently ignored errors but now that postcss processes them they break the build |
It's caused by my Probably linked to #224 |
Cloning cartesapp/cartes, switching to the "yak" branch and doing bun install && bun run build should trigger the error. The static/css/xxx files are not present anymore after the error is triggered, making it hard to find where it comes from in a large code base. |
@laem thank you so much - this is (probably) a bug in our parsing logic 🤯 in |
Thanks ! That was quite a peripheral unused page. How did you find out which one of the files was causing the build fail ? |
I modified the node_modules module which showed the "Unclosed Block" error message to get the full css code which caused the problem btw we have a fix in #227 |
https://cartes.app has switched fully to next-yak yesterday :) Was quite a large set of changes. I've tried Aider to assist me, with Mistral, it's impressive but too difficult to know if the set of changes doesn't include an error. So, manually. Prod works great. I have the impression that the app is faster in use. But it's very difficult to say. At least, the rehydratation errors have disappeared :) |
Really nice to hear. Thank you for pushing through the migration. We're currently also busy to migrate a part of a huge application to get some real world performance comparisons between |
Maybe we could add an experimental flag in the
withYak
config to automatically transpilestyled-components
code tonext-yak
. This feature would allow users to easily test existing styled-components-based projects with next-yak, potentially identifying performance improvements and compatibility issues.Benefits:
Proposed Implementation:
withYak
config, e.g.,library: "styled-components"
The text was updated successfully, but these errors were encountered: