Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for underscore separator in numbers #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for underscore separator in numbers #8

wants to merge 2 commits into from

Conversation

Victor4X
Copy link

Closes #7

If you want this implemented in a different way, feel free to tell me how :)

@netlify
Copy link

netlify bot commented Sep 20, 2022 •
edited
Loading

✅ Deploy Preview for calcutext ready!

Name Link
🔨 Latest commit 110841d
🔍 Latest deploy log https://app.netlify.com/sites/calcutext/deploys/6329666fac0a03000854149b
😎 Deploy Preview https://deploy-preview-8--calcutext.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Victor4X
Copy link
Author

Something must've changed between your last deploy and today, as netlify's deploy now fails with this error:

Failed to compile.
./src/Banner.js
  Line 222:21:  Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener  react/jsx-no-target-blank
​
────────────────────────────────────────────────────────────────
  "build.command" failed                                        
────────────────────────────────────────────────────────────────

I'm not sure if you want this fixed in a separate PR, but for now I will add a commit to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for underscores in numbers for improved readability
1 participant
@Victor4X