Improve reference link rendering

jaspervdj · jaspervdj · commit 140f203f5ca8 · 2025-03-24T17:31:41.000+01:00
This changes the way references are rendered from: [example](http://example.com/) [example with title](http://example.com/ "title") To: [example]: http://example.com/ [example with title]: http://example.com/ title This easier to read and more coherent with Pandoc markdown.
diff --git a/lib/Patat/Presentation/Display.hs b/lib/Patat/Presentation/Display.hs
@@ -469,12 +469,11 @@ prettyReferences ds =
         "[" <>
         themed ds themeLinkText
             (prettyInlines ds $ newlineToSpace text) <>
-        "](" <>
+        "]: " <>
         themed ds themeLinkTarget (PP.text target) <>
         (if T.null title
             then mempty
-            else PP.space <> "\"" <> PP.text title <> "\"")
-        <> ")"
+            else PP.space <> PP.text title)
 
     newlineToSpace :: [Inline] -> [Inline]
     newlineToSpace = runIdentity . dftInlines (pure . pure) work
diff --git a/tests/golden/outputs/links.md.dump b/tests/golden/outputs/links.md.dump
@@ -7,9 +7,9 @@
 
 [mLet's talk about [[0m[32mfoo[0m[m][0m
 
-[m[[0m[32minline link[0m[m]([0m[4;36m/url[0m[m)[0m
-[m[[0m[32mone with a title[0m[m]([0m[4;36mhttp://fsf.org[0m[m "click here for a good time!")[0m
-[m[[0m[32mfoo[0m[m]([0m[4;36mhttp://foo.com/[0m[m)[0m
+[m[[0m[32minline link[0m[m]: [0m[4;36m/url[0m
+[m[[0m[32mone with a title[0m[m]: [0m[4;36mhttp://fsf.org[0m[m click here for a good time![0m
+[m[[0m[32mfoo[0m[m]: [0m[4;36mhttp://foo.com/[0m
 [33m                                                                  1 / 2 [0m
 
 [m{slide}[0m
@@ -23,8 +23,8 @@
 [35m4.  [0m[mA [[0m[32mshortcut reference[0m[m] link[0m
 [35m5.  [0m[mA [[0m[32mtitled[0m[m] link[0m
 
-[m[[0m[32minline one[0m[m]([0m[4;36mhttp://example.com#2[0m[m)[0m
-[m[[0m[32mreference[0m[m]([0m[4;36mhttp://example.com#3[0m[m)[0m
-[m[[0m[32mshortcut reference[0m[m]([0m[4;36mhttp://example.com#4[0m[m)[0m
-[m[[0m[32mtitled[0m[m]([0m[4;36mhttp://example.com#5[0m[m "The title")[0m
+[m[[0m[32minline one[0m[m]: [0m[4;36mhttp://example.com#2[0m
+[m[[0m[32mreference[0m[m]: [0m[4;36mhttp://example.com#3[0m
+[m[[0m[32mshortcut reference[0m[m]: [0m[4;36mhttp://example.com#4[0m
+[m[[0m[32mtitled[0m[m]: [0m[4;36mhttp://example.com#5[0m[m The title[0m
 [33m                                                                  2 / 2 [0m

-Original file line number
+Diff line change
 [mLet's talk about [[0m[32mfoo[0m[m][0m
 -[m[[0m[32minline link[0m[m]([0m[4;36m/url[0m[m)[0m
 -[m[[0m[32mone with a title[0m[m]([0m[4;36mhttp://fsf.org[0m[m "click here for a good time!")[0m
 -[m[[0m[32mfoo[0m[m]([0m[4;36mhttp://foo.com/[0m[m)[0m
 +[m[[0m[32minline link[0m[m]: [0m[4;36m/url[0m
 +[m[[0m[32mone with a title[0m[m]: [0m[4;36mhttp://fsf.org[0m[m click here for a good time![0m
 +[m[[0m[32mfoo[0m[m]: [0m[4;36mhttp://foo.com/[0m
 [33m                                                                  1 / 2 [0m
 [m{slide}[0m
 [35m4.  [0m[mA [[0m[32mshortcut reference[0m[m] link[0m
 [35m5.  [0m[mA [[0m[32mtitled[0m[m] link[0m
 -[m[[0m[32minline one[0m[m]([0m[4;36mhttp://example.com#2[0m[m)[0m
 -[m[[0m[32mreference[0m[m]([0m[4;36mhttp://example.com#3[0m[m)[0m
 -[m[[0m[32mshortcut reference[0m[m]([0m[4;36mhttp://example.com#4[0m[m)[0m
 -[m[[0m[32mtitled[0m[m]([0m[4;36mhttp://example.com#5[0m[m "The title")[0m
 +[m[[0m[32minline one[0m[m]: [0m[4;36mhttp://example.com#2[0m
 +[m[[0m[32mreference[0m[m]: [0m[4;36mhttp://example.com#3[0m
 +[m[[0m[32mshortcut reference[0m[m]: [0m[4;36mhttp://example.com#4[0m
 +[m[[0m[32mtitled[0m[m]: [0m[4;36mhttp://example.com#5[0m[m The title[0m
 [33m                                                                  2 / 2 [0m