skipping temp. dir creation when removing temp. files

[trespasserw]

A temp. directory is not needed when an app doesn't unpack libraries from a classpath – e.g., sets jna.boot.library.path and only uses system libraries. Skipping directory creation decreases app startup time and reduces the chances of being locked by overzealous AV software.

[matthiasblaesing]

While I see what you are doing here, wouldn't it be as easy to just set the system property jna.nounpack to true? That way you make the intention clear and prevent the JNA automatic mechanisms from kicking in. From my POV that is the more complete solution to the stated problem.

[trespasserw]

(sorry for the noise, I keep forgetting this PR was created from the main branch)

That's correct, setting jna.nounpack would be more radical. But it might be too radical: I tried setting it once for IJ IDEA, and while the app itself was working just fine, it broke one of 3rd-party plugins. Though in this case a stricter behavior might be more important than compatibility 🤔

Please feel free to close.

[matthiasblaesing]

@trespasserw sorry for the late response. The change looks good to me and would be clear to merge. If it helps you, I'll get this in. If not I'll close. What should we do?

[trespasserw]

Let's close, for the sake of keeping things simpler. jna.nounpack does the job.