Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use page.path to determine which pages are ancestors #339

Open
ababic opened this issue Jul 13, 2019 · 0 comments
Open

Use page.path to determine which pages are ancestors #339

ababic opened this issue Jul 13, 2019 · 0 comments

Comments

@ababic
Copy link
Collaborator

ababic commented Jul 13, 2019

Currently wagtailmenus makes a database query to identify the page IDs of ancestors, and keeps it around in the context to help figure this out.

If we can work this out without a query, we should definitely do so. And with active class derivation becoming more efficient, we should just go ahead and apply it every time, and not make it optional.

@ababic ababic added this to the v3 milestone Jul 13, 2019
@ababic ababic self-assigned this Jul 13, 2019
@ababic ababic removed this from the v3 milestone Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant