-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wagtail 5.2 throws wagtailadmin.W002 warnings #464
Comments
This warning can be safely ignored. The add/edit views for wagtailmenus use this mixin, which takes care of creating an edit handler for the view to use. |
@ababic , do you think it makes sense filter out these specific warnings with |
@MrCordeiro if trivial, then sure. I can't say I'm very familiar with that API though. It looks a little cumbersome. |
Just a small update on that item. The warnings come from Django's system checks framework. The problem is that a third-party app can't directly manipulate checks registered by other apps (Wagtail, in this case). The workaround is having developers silence these warnings in their applications, using the # settings.py
SILENCED_SYSTEM_CHECKS = ["wagtailadmin.W002"] The problem with this, of course, is that it will also silence any instance where the warning shouldn't be ignored. So I don't recommend it. I'm going to close this issue for now. I'm also leaving a copy of @ababic's answer to #468 so that visitors can quickly find the reason why they can safely ignore those warnings:
|
When I upgrade wagtail version from 5.1.3 to 5.2, I got the following the warnings:
wagtailmenus.FlatMenu: (wagtailadmin.W002) FlatMenu.content_panels will have no effect on modeladmin editing
HINT: Ensure that FlatMenu uses
panels
instead ofcontent_panels
or set up anedit_handler
if you want a tabbed editing interface.There are no default tabs on non-Page models so there will be no Content tab for the content_panels to render in.
wagtailmenus.FlatMenu: (wagtailadmin.W002) FlatMenu.settings_panels will have no effect on modeladmin editing
HINT: Ensure that FlatMenu uses
panels
instead ofsettings_panels
or set up anedit_handler
if you want a tabbed editing interface.There are no default tabs on non-Page models so there will be no Settings tab for the settings_panels to render in.
wagtailmenus.MainMenu: (wagtailadmin.W002) MainMenu.content_panels will have no effect on modeladmin editing
HINT: Ensure that MainMenu uses
panels
instead ofcontent_panels
or set up anedit_handler
if you want a tabbed editing interface.There are no default tabs on non-Page models so there will be no Content tab for the content_panels to render in.
wagtailmenus.MainMenu: (wagtailadmin.W002) MainMenu.settings_panels will have no effect on modeladmin editing
HINT: Ensure that MainMenu uses
panels
instead ofsettings_panels
or set up anedit_handler
if you want a tabbed editing interface.There are no default tabs on non-Page models so there will be no Settings tab for the settings_panels to render in.
Wagtail version: 5.2
Wagtailmenu version: 3.1.9
The text was updated successfully, but these errors were encountered: