Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to retrieve a Node from a JNode #99

Open
acasteigts opened this issue Feb 29, 2020 · 3 comments
Open

Ability to retrieve a Node from a JNode #99

acasteigts opened this issue Feb 29, 2020 · 3 comments
Labels
enhancement ready This issue is fixed. It awaits to be released.
Milestone

Comments

@acasteigts
Copy link
Member

It might be useful to be able to retrieve the Node corresponding to a given JNode. For instance, this happened in an attempt to detect where a node was dropped after being dragged. To this effect, I suggest to add a method getNode() in class JNode.

@acasteigts
Copy link
Member Author

What's been done in branch feature/99-node-from-jnode:

  • Added a getNode() method in class JNode

Merged into develop.

@acasteigts acasteigts added the ready This issue is fixed. It awaits to be released. label Oct 11, 2021
@acasteigts
Copy link
Member Author

(Will be closed when released.)

@acasteigts acasteigts reopened this Oct 16, 2021
acasteigts added a commit that referenced this issue Nov 3, 2021
@remikey remikey added this to the next milestone Nov 4, 2021
@remikey
Copy link
Member

remikey commented Nov 4, 2021

Looks good to me. Ready to be shipped in next release.

Rmq: I don't think this new piece of code is used anywhere in the production/test/example code of the project. This is not vital, but we should try and add something in that direction, should the occasion arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ready This issue is fixed. It awaits to be released.
Projects
None yet
Development

No branches or pull requests

2 participants