Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

knn classify method in ch08 isn't quite right #19

Open
nico opened this issue Sep 2, 2014 · 1 comment
Open

knn classify method in ch08 isn't quite right #19

nico opened this issue Sep 2, 2014 · 1 comment

Comments

@nico
Copy link
Contributor

nico commented Sep 2, 2014

It computes a label -> vote mapping and then ignores the votes and just returns the highest label. The change to knn.py in nico/cvbook@bf567d2 fixes this.
@santjaqo
Copy link

I've just found the same issue. I am using the book draft available here:
http://programmingcomputervision.com/downloads/ProgrammingComputerVision_CCdraft.pdf
I have no access to O'Reilly's final edition, but apparently the issue is also in that version.

@nico wouldn't you like to pull request your fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nico @santjaqo