Fix warnings

Author: jfree

src/main/java/com/orsonpdf/Dictionary.java

@@ -53,7 +53,7 @@ public class Dictionary {
     private String type;
 
     /** Data storage. */
-    private Map<String, Object> map;
+    private final Map<String, Object> map;
 
     /**
      * Creates a new instance with no type.
@@ -170,7 +170,7 @@ public String toPDFString() {
             Object value = this.map.get(key);
             if (value instanceof Number || value instanceof String) {
                 b.append(key).append(" ");
-                b.append(value.toString()).append("\n");                
+                b.append(value).append("\n");
             } else if (value instanceof PDFObject) {
                 PDFObject pdfObj = (PDFObject) value;
                 b.append(key).append(" ");

src/main/java/com/orsonpdf/DictionaryObject.java

@@ -41,7 +41,7 @@
  */
 public class DictionaryObject extends PDFObject {
 
-    protected Dictionary dictionary;
+    protected final Dictionary dictionary;
 
     /**
      * Creates a new instance.

src/main/java/com/orsonpdf/FontKey.java

@@ -42,13 +42,13 @@
 public class FontKey {
 
     /** The key name. */
-    private String name;
+    private final String name;
 
     /** Flag for bold. */
-    private boolean isBold;
+    private final boolean isBold;
 
     /** Flag for italic. */
-    private boolean isItalic;
+    private final boolean isItalic;
 
     /**
      * Creates a new key for a given font.

src/main/java/com/orsonpdf/PDFDocument.java

@@ -37,7 +37,7 @@
 import java.io.FileNotFoundException;
 import java.io.FileOutputStream;
 import java.io.IOException;
-import java.io.UnsupportedEncodingException;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.Date;
 import java.util.List;
@@ -266,7 +266,7 @@ public byte[] getPDFBytes() {
             xref[xref.length - 1] = bos.size();
             // write the xref table
             bos.write(toBytes("xref\n"));
-            bos.write(toBytes("0 " + String.valueOf(this.nextNumber) 
+            bos.write(toBytes("0 " + this.nextNumber
                     + "\n"));
             bos.write(toBytes("0000000000 65535 f \n"));
             for (int i = 0; i < this.nextNumber - 1; i++) {
@@ -284,8 +284,7 @@ public byte[] getPDFBytes() {
             trailer.put("/Info", this.info);
             bos.write(trailer.toPDFBytes());
             bos.write(toBytes("startxref\n"));
-            bos.write(toBytes(String.valueOf(xref[this.nextNumber - 1]) 
-                    + "\n"));
+            bos.write(toBytes(xref[this.nextNumber - 1] + "\n"));
             bos.write(toBytes("%%EOF"));
         } catch (IOException ex) {
             throw new RuntimeException(ex);
@@ -328,11 +327,7 @@ public void writeToFile(File f) {
      */
     private byte[] toBytes(String s) {
         byte[] result = null;
-        try {
-            result = s.getBytes("US-ASCII");
-        } catch (UnsupportedEncodingException ex) {
-            throw new RuntimeException(ex);
-        }
+        result = s.getBytes(StandardCharsets.US_ASCII);
         return result;
     }
 

src/main/java/com/orsonpdf/PDFUtils.java

@@ -33,7 +33,7 @@
 
 import com.orsonpdf.util.Args;
 import java.awt.geom.AffineTransform;
-import java.io.UnsupportedEncodingException;
+import java.nio.charset.StandardCharsets;
 import java.text.DateFormat;
 import java.text.SimpleDateFormat;
 import java.util.Calendar;
@@ -62,7 +62,7 @@ public static String toPDFArray(boolean[] b) {
             if (i != 0) {
                 sb.append(" ");
             }
-            sb.append(String.valueOf(b[i]));
+            sb.append(b[i]);
         }
         return sb.append("]").toString();
     }
@@ -81,7 +81,7 @@ public static String toPDFArray(float[] f) {
             if (i != 0) {
                 b.append(" ");
             }
-            b.append(String.valueOf(f[i]));
+            b.append(f[i]);
         }
         return b.append("]").toString();
     }
@@ -100,7 +100,7 @@ public static String toPDFArray(double[] d) {
             if (i != 0) {
                 b.append(" ");
             }
-            b.append(String.valueOf(d[i]));
+            b.append(d[i]);
         }
         return b.append("]").toString();
     }
@@ -170,11 +170,7 @@ public static String toPDFDateFormat(Calendar calendar) {
      */
     public static byte[] toBytes(String s) {
         byte[] result = null;
-        try {
-            result = s.getBytes("US-ASCII");
-        } catch (UnsupportedEncodingException ex) {
-            throw new RuntimeException(ex);
-        }
+        result = s.getBytes(StandardCharsets.US_ASCII);
         return result;
     }
 

src/main/java/com/orsonpdf/Page.java

@@ -281,11 +281,10 @@ private Function createFunctionForMultipleGradient(
         PDFDocument doc = this.parent.getDocument();
 
         if (mgp.getColors().length == 2) {
-            Function f = new ExponentialInterpolationFunction(
+            return new ExponentialInterpolationFunction(
                     doc.getNextNumber(),
-                    mgp.getColors()[0].getRGBColorComponents(null), 
+                    mgp.getColors()[0].getRGBColorComponents(null),
                     mgp.getColors()[1].getRGBColorComponents(null));
-            return f;
         } else {
             int count = mgp.getColors().length - 1;
             Function[] functions = new Function[count];