Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If user has $(dollar) in the password, the build will get failed #257

Closed
pavanvikas opened this issue May 20, 2021 · 3 comments · Fixed by #294
Closed

If user has $(dollar) in the password, the build will get failed #257

pavanvikas opened this issue May 20, 2021 · 3 comments · Fixed by #294
Assignees
Labels
bug Something isn't working

Comments

@pavanvikas
Copy link

pavanvikas commented May 20, 2021

Describe the bug
If we configure the Artifactory user with $(dollar) in his password, the build will get failed when triggered from Azure pipelines.

To Reproduce

  1. Create an Artifactory admin user which has $(dollar) in his password.
  2. Configure Artifactory URL with the above created user, under Service connections at Azure end. Please note, when clicked on the Verify button it shows Verification Succeeded message.
    Now when executed the docker build this will fail. However, when running the same build with the same user by changing the password without $(dollar) in it, this will get succeeded.

Expected behavior
Build should get succeeded even though the user has $(dollar) in the password

Screenshots
Attached the screenshot for the failure and successful build.

Please find below environment details:
Artifactory v7.18.6
Current agent version: '2.186.1'
JFrog Artifactory Extension version1.12.2

Build log when the user has $(dollar) in the password:
non-working_log

Build log when the user DOES NOT have $(dollar) in the password:
working-log

Additional context
Add any other context about the problem here.

@pavanvikas pavanvikas added the bug Something isn't working label May 20, 2021
@pavanvikas pavanvikas changed the title Artifactory user has $(dollar) in his password, the build will get failed If user has $(dollar) in the password, the build will get failed May 20, 2021
@NinoCapo
Copy link

@pavanvikas Just an idea, but that may be because Azure Pipelines treat anything with the $(***) as a variable.

@sverdlov93 sverdlov93 self-assigned this Dec 20, 2021
sverdlov93 referenced this issue Dec 30, 2021
Fix repo-path param and double quote issue
@sverdlov93 sverdlov93 linked a pull request Dec 30, 2021 that will close this issue
3 tasks
sverdlov93 added a commit that referenced this issue Dec 30, 2021
@sverdlov93
Copy link
Contributor

sverdlov93 commented Jan 13, 2022

Hi @pavanvikas and @NinoCapo ,
First of all, We just released extension version 1.13.4 which includes a fix for the above issue.
We'd appreciate your feedback on it.

Also, as part of our effort of enhancing the integration between the JFrog Platform and Azure DevOps, we recently released a new extension to Azure DevOps - JFrog Azure DevOps Extension.
The new extension also includes a fix for this issue.

Read more about why we created a new extension and what's new.
The documentation of the new extension can be found here.
We'd appreciate your feedback about the capability and the new extension once you try it out.
Thanks!

@shuvadipc
Copy link

This was fixed. Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants