Internal - Remove the Call Home version validation #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eyalbe4
commented
Dec 25, 2024
eyalbe4
commented
- Remove the minimum Artifactory version validation before sending the Call Home requests, since the validation moves to the caller of the API. This is done to avoid duplicate "Get Artifactory Version" requests.
- Rename the API functions, to force the callers to adapt to this change.
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
EyalDelarea
requested changes
Dec 25, 2024
There was a problem hiding this comment.
@eyalbe4,
What happens if, as a future implementer, I fail to check the minimum version? How will I know?
I know the functions names has changed, but it does not enforce a version check.
Also, how will I know the minimum version needed now that it has moved to the core? assuming i'm a developer who do want to validate on my end.
|
@EyalDelarea, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.