Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Username and Description to Access token commands #759

Closed
wants to merge 1 commit into from
Closed

Add Username and Description to Access token commands #759

wants to merge 1 commit into from

Conversation

Smirl
Copy link

@Smirl Smirl commented May 11, 2023

Summary

The new Access token APIs allow for a description and username to be set.

The description can be used to search for tokens once they are created. The username can be used by admins to create tokens on behalf of other users, or to create temporary users that belong to a group.

This PR also adds these two existing methods to the README.

Fixes and helps some issues

closes #739
closes #727 (already there but issue still open, this now documents this in the README)
Might help with #753 as description can now be added.

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Smirl Smirl changed the base branch from master to dev May 11, 2023 20:23
@Smirl
Copy link
Author

Smirl commented May 11, 2023

I have read the CLA Document and I hereby sign the CLA

recheck

@Smirl Smirl force-pushed the create-token-params branch from 369cc9b to 74e57a9 Compare May 11, 2023 20:27
@Smirl
Copy link
Author

Smirl commented May 11, 2023

I have read the CLA Document and I hereby sign the CLA

@eyalbe4 eyalbe4 self-requested a review May 12, 2023 05:48
@Smirl Smirl mentioned this pull request May 12, 2023
Open
@Smirl
Copy link
Author

Smirl commented May 12, 2023

Hi @yahavi

Quick PR (with a follow up that I will rebase after this is merged). Thanks!

@Smirl Smirl force-pushed the create-token-params branch from 74e57a9 to deead89 Compare June 1, 2023 10:13
@Smirl
Copy link
Author

Smirl commented Jun 1, 2023

Hi @yahavi @sverdlov93

I have rebased this to get it back up to date with dev. Let me know if you have any comments 😄

@Smirl Smirl force-pushed the create-token-params branch from deead89 to 9071933 Compare June 13, 2023 11:06
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 20, 2023
eyalbe4
eyalbe4 requested changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's resolve the conflicts.

README.md Outdated
@@ -1477,6 +1477,41 @@ err = accessManager.UpdateGroupInProject("tstprj", "tstgroup", projectGroup)
err = accessManager.DeleteExistingProjectGroup("tstprj", "tstgroup")
```

#### Create an access token for the JFrog Platform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create an access token for the JFrog Platform --> Create an access token

Let's add this section to table of contents.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thank you for the review

README.md Show resolved Hide resolved
@eyalbe4 eyalbe4 self-requested a review July 20, 2023 08:00
@Mavrickk3 Mavrickk3 mentioned this pull request Aug 14, 2023
Closed
4 tasks
@eyalbe4
Copy link
Contributor

eyalbe4 commented Aug 31, 2023

@Smirl,
Are you planning to continue promoting this PR?

@eyalbe4
Copy link
Contributor

eyalbe4 commented Aug 31, 2023

Oh - I see now that #810 is meant to replace this PR.

@Smirl
Copy link
Author

Smirl commented Sep 3, 2023

Sorry for the delayed reply I hadn't checked in on this PR for a while. I can make the changes to the README on Monday.

@Smirl Smirl force-pushed the create-token-params branch from 9071933 to 0893790 Compare September 4, 2023 21:16
@Smirl
Copy link
Author

Smirl commented Sep 4, 2023

@eyalbe4 I have added the changes you asked for. Sorry for the delay. Should close the duplicate #810

@eyalbe4
Copy link
Contributor

eyalbe4 commented Nov 22, 2023

@Smirl,
While looking at the conflicts this PR has with the dev branch, I saw that the Username and Description fields have already been added to the dev branch/ Is this PR still needed?
image

@Smirl
Copy link
Author

Smirl commented Nov 29, 2023

Closing as fixed in another PR

@Smirl Smirl closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mavrickk3 Mavrickk3 Mavrickk3 approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Smirl @eyalbe4 @Mavrickk3