Skip to content
This repository has been archived by the owner on Oct 25, 2021. It is now read-only.

Some questions. #29

Open
rilian-la-te opened this issue Feb 9, 2018 · 4 comments
Open

Some questions. #29

rilian-la-te opened this issue Feb 9, 2018 · 4 comments

Comments

@rilian-la-te
Copy link
Contributor

rilian-la-te commented Feb 9, 2018

What do you think about:

  1. Implementing StatusNotifier (no dependencies, except gdbus-codegen, which is bundled with GLib)
  2. Bumping required GTK version to GTK3.18 (or 3.22)
  3. Replacing GtkNotebook to GtkStack
  4. Adding .clang-format file to easier styling new code
@SolarAquarion
Copy link

@jgke

@SolarAquarion
Copy link

You may need to fork it?

@jgke
Copy link
Owner

jgke commented Jun 25, 2018

Whoops, forgot to reply to these, been quite busy with life... sorry about that.

Ahem.

  1. Sure! I originally went with GtkStatusIcon because it was available in GTK and was readily available.
  2. Why not, if there's need for it. Since 3.22 is already at Debian Stable, I guess it's pretty safe to upgrade directly to it :)
  3. Is there a reason for switching? GtkNotebook works fine in my opinion.
  4. Why not, the project tries to follow connman's coding style. Astyle/clang's formatter/whatever might make that easier.

@rilian-la-te
Copy link
Contributor Author

  1. I will try to implement it (but I need to port my local StatusNotifier library from Vala to C)
  2. 3.22 contains many new APIs, so, it worth to upgrade.
  3. For me, GtkStackSidebar is more beautiful than GtkNotebook and one stack can be bound to multiple tabs.
  4. Can you add .clang-format to this project?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants