New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homography decomposition #6

Open

stefanklut opened this issue Apr 14, 2021 · 1 comment

Contributor

stefanklut commented Apr 14, 2021

Hi there,

Awesome work, I just have a couple of questions on the metrics.py

Currently I believe the scale extraction and the rotation extraction are done incorrectly. Based on https://math.stackexchange.com/questions/78137/decomposition-of-a-nonsquare-affine-matrix taking the diagonal of the matrix seems incorrect for computing these values. I am happy to discuss this with you.

Thanks in advance

Owner

jinsc37 commented Apr 14, 2021 via email

Hi, sorry for the late reply Could you send a PR? I can look through it Thanks!

On Wed, Apr 14, 2021 at 3:52 AM Stefan Klut ***@***.***> wrote: Hi there, Awesome work, I just have a couple of questions on the metrics.py Currently I believe the scale extraction and the rotation extraction are done incorrectly. Based on https://math.stackexchange.com/questions/78137/decomposition-of-a-nonsquare-affine-matrix taking the diagonal of the matrix seems incorrect for computing these values. I am happy to discuss this with you. Thanks in advance — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE2XT6KZ3OIOY6RQLYK25NLTIVXXZANCNFSM425ENZYQ> .

stefanklut mentioned this issue

Fixing homography decomposition #7

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment