Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with socket.io-prometheus-metrics #13

Open
pouriamoosavi opened this issue Aug 29, 2023 · 2 comments
Open

Problem with socket.io-prometheus-metrics #13

pouriamoosavi opened this issue Aug 29, 2023 · 2 comments

Comments

@pouriamoosavi
Copy link

pouriamoosavi commented Aug 29, 2023

Hello hope you are well.

I was trying to install this module on a self hosted Jitsi server and I faced a problem with 9090 port. I had another program that was running on this port and I didn't want to stop it.
I deleted this part and everything seems to be working correctly:

// listens on host:9090/metrics
prometheus.metrics(io, {
    collectDefaultMetrics: true
});

The thing is that I think we can make this (whatever it is) optional and enable it only if user asks for it.

As I had provided my desired port in .env file it was very confusing at first that it was asking for 9090 port to be open.

@saghul
Copy link
Member

saghul commented Sep 14, 2023

Good point. Would you like to send a PR making it optional with an env variable?

@alkanpolat
Copy link

alkanpolat commented Oct 2, 2023

Hi, can you help with this issue?

I set the port to 9091 in the index.ts file, but the drawings I made do not appear on the other user's screen. I get "WebSocket connection failed error" in the console

// listens on host:9090/metrics
prometheus.metrics(io, {
    port:9091,
    collectDefaultMetrics: true
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants