Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jive.community.doRequest looks for community for no reason #33

Open
naugtur opened this issue Oct 16, 2014 · 4 comments
Open

jive.community.doRequest looks for community for no reason #33

naugtur opened this issue Oct 16, 2014 · 4 comments

Comments

@naugtur
Copy link

naugtur commented Oct 16, 2014

When a request is being done, one of the steps is finding the community

return exports.findByCommunity(community['jiveCommunity']).then( function( community ) {

the retrieved community variable is checked for not being null and never used again.
If I override the .findByCommunity to return a truthily-resolved promise, it just works and makes the query.

@rachoac
Copy link
Collaborator

rachoac commented Oct 20, 2014

It should not make the query if the system doesn't really have a record of the target community.

@naugtur
Copy link
Author

naugtur commented Oct 20, 2014

But then how do I use External Storage Framework when sending metadata to Jive?
Nothing in there seems to store any communities and doRequest is the only method of its kind in the SDK that goes through the process of refreshing the oauth token if needed.
We can move this conversation to your support location.

@rachoac
Copy link
Collaborator

rachoac commented Oct 20, 2014

Support location?

Sent from Yahoo Mail for iPhone

@naugtur
Copy link
Author

naugtur commented Oct 20, 2014

General developer support issues are discused in jive community portal. that's what I meant. We can discuss it there if you're certain this issue is invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants