Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger wont be removed if JobConcurrentExecutionDisallowed is true and no nextFireTime set (Version 1.1.9) #30

Open
roeder82 opened this issue Jan 5, 2018 · 0 comments

Comments

@roeder82
Copy link

roeder82 commented Jan 5, 2018

Given the following scenario:

  • Job with isJobConcurrentExecutionDisallowed(job.getJobClass()) == true
  • trigger.getNextFireTime() == null

In this case in RedisStorage.triggersFired the else case in line 744 ( jedis.hset(triggerHashKey, TRIGGER_NEXT_FIRE_TIME, "")) is not executed, as there is an else if else from "if (isJobConcurrentExecutionDisallowed(job.getJobClass()))", therefor the trigger wont be removed in RedisStorage.triggeredJobComplete line 818 (if(isNullOrEmpty(jedis.hget(triggerHashKey, TRIGGER_NEXT_FIRE_TIME)))) as the expression evaluates to false.

This leads to jobs running and running again even though the shall be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant