Fix build with Python 3.13+ #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using PyObject_AsReadBuffer, do what PyObject_AsReadBuffer does. Note that this is not safe, and it has never been safe, but the code does *exactly* what it used to do (at least on Python 3.8+). Fixes jnwatson#362 Co-Authored-By: Miro Hrončok <[email protected]>
|
Please do not use #if PY_VERSION_HEX < 0x030d0000
.
.
#else
.
.
#endifBecause this makes that code not pyupgradeable. if sys.version_info < (3, 13):
.
.
else:
.
.This would allow in the future drop first part of the code on use |
|
Tomasz, this is C. Feel free to submit an alternate PR, but I won't try to figure out how to make changes in C pyupgradeable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using PyObject_AsReadBuffer, do what PyObject_AsReadBuffer does.
Note that this is not safe, and it has never been safe, but the code does exactly what it used to do (at least on Python 3.8+).
Fixes #362