Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is hash key symbol (#) allowed in Joomla language key? #312

Open
joomlagate opened this issue Oct 3, 2016 · 3 comments
Open

Is hash key symbol (#) allowed in Joomla language key? #312

joomlagate opened this issue Oct 3, 2016 · 3 comments

Comments

@joomlagate
Copy link

joomlagate commented Oct 3, 2016

Steps to reproduce the issue

open the backend language file of Easyblog component:

filename: en-GB.plg_easyblog_pagebreak.ini , line 13 is:

PLG_PAGEBREAK_PAGE_#="Page %s"
When translating this file with localise v4.0.21dev, localise component will show warning message that this line is wrong: the "#" symbol (AKA "Number Sign") should NOT in a language key.

System information (as much as possible)

Joomla 3.6.2
PHP 7.0
localise v4.0.21dev

Additional comments

I am not sure if hash symbol (#) is allowed in Joomla language key? If not, this is a bug of Easyblog; if yes, this is a bug of com_localise.

Thank you.

@mbabker
Copy link
Contributor

mbabker commented Oct 3, 2016

As of 3.6.3 you can run JFactory::getLanguage()->debugFile($filename); and that will tell you if the file passes core's rules (this is the same debug code that runs in 3.6.2 and earlier when the file is parsed but now made available as a separate public API).

The line format is expected to pass https://github.com/joomla/joomla-cms/blob/3.6.3-rc1/libraries/joomla/language/language.php#L932

@joomlagate
Copy link
Author

Can you just confirm that if the following line is correct or wrong ( because com_localise reported it as error) :

PLG_PAGEBREAK_PAGE_#="Page %s"

@mbabker
Copy link
Contributor

mbabker commented Oct 3, 2016

I don't know, I can't regex my way out of a wet brown paper bag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants