[javascript] fix: runCommand fix new line added

Author: jooy2

docs/src/en/reference/os/runCommand.md

@@ -10,10 +10,10 @@ It returns the result that is output after entering and executing the command pr
 
 ## Returns
 
-> string
+> string | null
 
 ## Examples
 
 ```javascript
-console.log(await runCommand('echo a')); // Returns 'a\n'
+console.log(await runCommand('echo a')); // Returns 'a'
 ```

docs/src/ko/reference/os/runCommand.md

@@ -10,10 +10,10 @@
 
 ## Returns
 
-> string
+> string | null
 
 ## Examples
 
 ```javascript
-console.log(await runCommand('echo a')); // Returns 'a\n'
+console.log(await runCommand('echo a')); // Returns 'a'
 ```

packages/javascript/lib/node/os/getMachineId.ts

@@ -18,7 +18,11 @@ export async function getMachineId(): Promise<string> {
 	}
 
 	try {
-		return await runCommand(command);
+		const response = await runCommand(command);
+
+		if (response) {
+			return response;
+		}
 	} catch (error) {
 		if (error instanceof Error) {
 			throw new Error(error?.message);

packages/javascript/lib/node/os/getSid.ts

@@ -11,6 +11,10 @@ export async function getSid(): Promise<string> {
 				`REG QUERY "HKLM\\SOFTWARE\\Microsoft\\Windows NT\\CurrentVersion\\ProfileList" /s`
 			);
 
+			if (!profileLists) {
+				throw new Error('Failed to get machine id');
+			}
+
 			const profiles: AnyValueObject = {};
 			const sections = profileLists.split('HKEY_LOCAL_MACHINE\\');
 

packages/javascript/lib/node/os/runCommand.ts

@@ -1,7 +1,7 @@
 import { exec as processExec } from 'child_process';
-import { platform } from 'os';
+import { EOL } from 'os';
 
-export function runCommand(command: string): Promise<string> {
+export function runCommand(command: string): Promise<string | null> {
 	return new Promise((resolve, reject) => {
 		const execCommandProcess = processExec(
 			command,
@@ -12,16 +12,11 @@ export function runCommand(command: string): Promise<string> {
 					return;
 				}
 
-				const output = platform() === 'win32' ? stdout : stdout.split('\r\n')?.[0] || '';
+				const output = stdout.split(EOL)?.[0];
 
 				execCommandProcess?.stdin?.end();
 
-				if (output) {
-					resolve(output);
-					return;
-				}
-
-				reject(new Error(`Command failed`));
+				resolve(output);
 			}
 		);
 	});

packages/javascript/test/os.test.ts

@@ -4,8 +4,8 @@ import { runCommand, getMachineId, getSid } from '../dist/node';
 
 describe('OS', () => {
 	it('runCommand', async () => {
-		assert.strictEqual(await runCommand('echo a'), 'a\n');
-		assert.strictEqual(await runCommand('echo b'), 'b\n');
+		assert.strictEqual(await runCommand('echo a'), 'a');
+		assert.strictEqual(await runCommand('echo b'), 'b');
 	});
 
 	/*