Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation #65

Open
g7sim opened this issue May 19, 2020 · 0 comments
Open

Installation #65

g7sim opened this issue May 19, 2020 · 0 comments

Comments

@g7sim
Copy link

g7sim commented May 19, 2020

A. In the readme You load content_css: 'https://netdna.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css', --- in the plugin.js stands : var version = 'v5.12.0';
Can You change to the real link - i think it is https://cdn.jsdelivr.net/npm/@fortawesome/[email protected]/css/all.min.css (evtl. it is possible to add the fonts in a directory and also the all.min.css)

B. Also some icons are grayed out - evtl. the specific mce-fontawesome.css is not complete (or the css is for the pro)

C. Can You please change the name of the installation-directory from fontawesome to fontawe5 (or similar) so that compatibility with older (also other) versions is made sure.
tinymce.PluginManager.add('fontawesome' ... to ... tinymce.PluginManager.add('fontawe5'..... etc.

D. I dont want to talk unmodest about options like font-size, colors and rotation etc.) which the ckeditor-version has (just a proposal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant