Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make skin fix fetch skin from Mojang API instead of 3rd party service #10

Open
forkiesassds opened this issue Feb 21, 2023 · 3 comments

Comments

@forkiesassds
Copy link
Contributor

Avoids issues where skins can be cached for an extended period of time, along side potentially fixing false positive where Steve skins are flagged as Alex skins

@js6pak
Copy link
Owner

js6pak commented Feb 21, 2023

MojangFix can already use the mojang api (https://github.com/js6pak/mojangfix/blob/master/src/main/java/pl/js6pak/mojangfix/client/skinfix/provider/MojangProfileProvider.java) but it only does so as a last resort because it has a much stricter rate limit and requires 2 requests (name -> uuid and uuid -> skin)

@telvarost
Copy link

Added a config to change priority to Mojang over AshCon (default false) if you prefer to get the skin from Mojang.
https://github.com/telvarost/MojangFix-StationAPI

Open to discussion on this. Once again feel free to contact me if there are any issues with this comment or the fork. Trying to provide a variant with all the configs that users would like (so even more forks don't get created). Thanks!

@telvarost
Copy link

Using jankson I was able to create a version of the mod that doesn't use StationAPI and GCAPI if you are interested in the changes being part of the main mod just let me know and we can upstream them 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants