Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sheet name #78

Closed
alex88 opened this issue Jul 9, 2018 · 3 comments
Closed

Sheet name #78

alex88 opened this issue Jul 9, 2018 · 3 comments
Labels
enhancement

Comments

@alex88
Copy link

alex88 commented Jul 9, 2018

Is there a way to get the sheet name when extracting data?
@jsonkenl
Copy link
Owner

Hey @alex88, yes there is but Xlsxir is not currently capable of capturing it. The information is located in the xl/workbook.xml file within the .xlsx document. I'll need to parse that file anyway to fix the 1904 date issue from #75, so I'll add this as an enhancement to add to that one. Feel free to take a stab at it if you have any interest.

@norpan
Copy link

norpan commented Oct 3, 2018 •
edited
Loading

I made a quick implementation of a parser that puts worksheet names into an ets table. However, I'm not sure how to incorporate it into the API. Also, I used mix format so the diff is bigger than it should be. See norpan@456a6cf

@jsonkenl
Copy link
Owner

jsonkenl commented Jan 3, 2019

This has been implemented via PR #82

@jsonkenl jsonkenl closed this as completed Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alex88 @norpan @jsonkenl