Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: openapi schema, rekorLogId should be nullable #885

Open
HuakunShen opened this issue Jan 8, 2025 · 1 comment
Open

Bug: openapi schema, rekorLogId should be nullable #885

HuakunShen opened this issue Jan 8, 2025 · 1 comment
Labels
good first issue Good for newcomers

Comments

@HuakunShen
Copy link

I am using the openapi schema (https://api.jsr.io/.well-known/openapi) to generate client.
And I noticed an error in the schema

Here is the schema for rekorLogId

rekorLogId:
          type: string
          description: Rekor log ID for the published package version.

But when a package isn't signed by github action, its rekorLogId is null.
I believe a nullable: true should be added to the schema.

@github-project-automation github-project-automation bot moved this to Needs Triage in JSR Jan 8, 2025
@lucacasonato lucacasonato added good first issue Good for newcomers bug labels Jan 8, 2025
@lucacasonato
Copy link
Member

We'd welcome a PR to the schema here: https://github.com/jsr-io/jsr/blob/main/api/src/api.yml

@crowlKats crowlKats removed the bug label Jan 16, 2025
@crowlKats crowlKats moved this from Needs Triage to Ready in JSR Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Ready
Development

No branches or pull requests

3 participants