Update 1.8.2 -> 1.9.1: old file attachments missing

[chaotix-]

After updating to 1.9.1 my oldest file attachments where gone. The attachments itself are still there but there is no reference to the files anymore.

I checked the MySQL database and it seems it might be an older bug that just now causes problems. All the affected file attachments where older than 2017-09-24 and did not have the backref column set in utils_filestorage.

Looking at modules/Utils/Attachment/patches/20171024_use_generic_file_field.php shows the problem: Only attachments with backref set are converted in the patch.

The following SQL statement before redoing the update fixed the problem:

UPDATE utils_filestorage, utils_attachment_file SET backref = CONCAT('rb:utils_attachment/', attach_id) WHERE utils_attachment_file.id = SUBSTR(link,17) AND backref IS NULL;

[chaotix-]

I just noticed that the files are there after the SQL statement, but file metadata is missing (who it was uploaded by and the number of downloads). The date of upload is still correct. Strange...