Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple client connections over Websocket #252

Open
janaab11 opened this issue Nov 17, 2024 · 3 comments
Open

Support multiple client connections over Websocket #252

janaab11 opened this issue Nov 17, 2024 · 3 comments
Labels
feature New feature or request
Milestone
Version 0.10

Comments

@janaab11
Copy link

janaab11 commented Nov 17, 2024 •
edited
Loading

Looked at the WebSocketAudioSource class to realise that the server will only support one client at a time. Also leads to this weird (but expected, i guess) behaviour - when two clients connect sequentially, the later one has response offsets that carry over from the first one.

I can see a way to add multi-client support - happy to make a PR - but wondering if this choice is intentional? And if i am missing something?

New here, and really appreciate the detail and thought that has gone into this work already!
@janaab11 janaab11 changed the title Support multiple client connections Support multiple client connections over Websocket Nov 17, 2024
@janaab11 janaab11 mentioned this issue Nov 22, 2024
Merged
@juanmc2005
Copy link
Owner

Hi @janaab11, thank you for opening this PR! Indeed the single-client is a limitation and would be glad to make it multi-client. I'll review your PR.

@juanmc2005 juanmc2005 self-assigned this Dec 13, 2024
@juanmc2005 juanmc2005 added the feature New feature or request label Dec 13, 2024
@juanmc2005 juanmc2005 added this to the Version 0.9.2 milestone Dec 13, 2024
@juanmc2005
Copy link
Owner

Could you please open the PR against the develop branch of diart instead of your fork? Then I'll be able to review it. Thanks!

@juanmc2005 juanmc2005 mentioned this issue Dec 13, 2024
Closed
@juanmc2005 juanmc2005 removed their assignment Dec 13, 2024
@janaab11 janaab11 mentioned this issue Dec 22, 2024
Open
@janaab11
Copy link
Author

Hi @juanmc2005, i have opened the PR. Sorry for the delay, look forward to working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
Version 0.10
Development

No branches or pull requests
2 participants
@juanmc2005 @janaab11