Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to parse DBCs represented as strings #14

Open
cosmin-radu opened this issue Jul 17, 2024 · 3 comments
Open

Possibility to parse DBCs represented as strings #14

cosmin-radu opened this issue Jul 17, 2024 · 3 comments

Comments

@cosmin-radu
Copy link

Hi everyone,

We want to reuse CANBabel library for a Java project in order to parse DBC stored in a database and then reuse the obtained details of parsed signals for different manipulations.

However, I saw the library allows only to parse a DBC from files, but, in my case, the content of the DBC is stored as a string. Also, I saw the internal field of the DbcReader (bus) wasn't exposed outside, so I couldn't use the obtained details.

I have created #13 PR that solves the issues (my editor also did automatically some extra changes for imports + casts).

Could you integrate the changes?

Thanks in advance!
Cosmin

@cristian-spiescu
Copy link

Hello.

Do you think you can find a bit of time to take a look at this and merge it?

Thanks! 🙂

@julietkilo
Copy link
Owner

Hello Cosmin, the code provided does not contain any tests or test classes to prove that your code works correctly in case of regression. If you want me to consider a merge, add test classes and change the code only in places where it is really necessary. BR Jens

@cosmin-radu
Copy link
Author

cosmin-radu commented Jan 8, 2025

Hi Jens!

I made a new PR, #15, where I let only the necessary changes and I add a test for parsing a string with DbcReader. Could you take a look to merge it?

Thanks!
Cosmin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants