You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We want to reuse CANBabel library for a Java project in order to parse DBC stored in a database and then reuse the obtained details of parsed signals for different manipulations.
However, I saw the library allows only to parse a DBC from files, but, in my case, the content of the DBC is stored as a string. Also, I saw the internal field of the DbcReader (bus) wasn't exposed outside, so I couldn't use the obtained details.
I have created #13 PR that solves the issues (my editor also did automatically some extra changes for imports + casts).
Could you integrate the changes?
Thanks in advance!
Cosmin
The text was updated successfully, but these errors were encountered:
Hello Cosmin, the code provided does not contain any tests or test classes to prove that your code works correctly in case of regression. If you want me to consider a merge, add test classes and change the code only in places where it is really necessary. BR Jens
Hi everyone,
We want to reuse CANBabel library for a Java project in order to parse DBC stored in a database and then reuse the obtained details of parsed signals for different manipulations.
However, I saw the library allows only to parse a DBC from files, but, in my case, the content of the DBC is stored as a string. Also, I saw the internal field of the
DbcReader
(bus) wasn't exposed outside, so I couldn't use the obtained details.I have created #13 PR that solves the issues (my editor also did automatically some extra changes for imports + casts).
Could you integrate the changes?
Thanks in advance!
Cosmin
The text was updated successfully, but these errors were encountered: