Skip to content

Move computing the ideal point after the optimizer has run #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

odow
Copy link
Member

@odow odow commented Apr 8, 2025

We should probably time out generating primal solutions, not computing the objective bound.

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (65b565d) to head (093a0a8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files           9        9           
  Lines         980      980           
=======================================
  Hits          968      968           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@remi-garcia
Copy link
Contributor

remi-garcia commented Apr 8, 2025

It would be nice if it were an option. And maybe in some cases, it could be better to not compute it at all. For instance, when we reoptimize with different weights for a Hierarchical, computing it a single time is enough.

@odow
Copy link
Member Author

odow commented Apr 8, 2025

See https://github.com/jump-dev/MultiObjectiveAlgorithms.jl/tree/master?tab=readme-ov-file#ideal-point

set_attribute(model, MOA.ComputeIdealPoint(), false)

@odow odow merged commit af7ce29 into master Apr 8, 2025
7 checks passed
@odow odow deleted the od/move-ideal-point branch April 8, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants