From f9c84034360d714fa71af255ddf349557a846e2d Mon Sep 17 00:00:00 2001 From: Ian Hunt-Isaak Date: Wed, 8 Mar 2023 16:57:59 -0500 Subject: [PATCH 1/2] fix: installation instructions --- README.md | 1 + .../.github/workflows/build.yml | 1 + {{cookiecutter.github_project_name}}/README.md | 1 + {{cookiecutter.github_project_name}}/pyproject.toml | 4 ++-- 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index b382bb8..83d6bc3 100644 --- a/README.md +++ b/README.md @@ -51,6 +51,7 @@ Install the python. This will also build the TS package. ```bash # First install the python package. This will also build the JS packages. +yarn install pip install -e ".[test, examples]" # Run the python tests. This should not give you a few sucessful example tests diff --git a/{{cookiecutter.github_project_name}}/.github/workflows/build.yml b/{{cookiecutter.github_project_name}}/.github/workflows/build.yml index dfab4e3..e5ce000 100644 --- a/{{cookiecutter.github_project_name}}/.github/workflows/build.yml +++ b/{{cookiecutter.github_project_name}}/.github/workflows/build.yml @@ -26,6 +26,7 @@ jobs: npm install -g codecov - name: Test the extension run: | + yarn install python -m pip install --upgrade -v -e ".[test, examples, docs]" python -m pytest yarn run test diff --git a/{{cookiecutter.github_project_name}}/README.md b/{{cookiecutter.github_project_name}}/README.md index f85ca0f..23ed8be 100644 --- a/{{cookiecutter.github_project_name}}/README.md +++ b/{{cookiecutter.github_project_name}}/README.md @@ -31,6 +31,7 @@ conda activate {{ cookiecutter.python_package_name }}-dev Install the python. This will also build the TS package. ```bash +yarn install pip install -e ".[test, examples]" ``` diff --git a/{{cookiecutter.github_project_name}}/pyproject.toml b/{{cookiecutter.github_project_name}}/pyproject.toml index 906333c..c424276 100644 --- a/{{cookiecutter.github_project_name}}/pyproject.toml +++ b/{{cookiecutter.github_project_name}}/pyproject.toml @@ -1,6 +1,6 @@ [build-system] requires = [ - "hatchling>=1.3.1", + "hatchling>=1.6.0", "jupyterlab==3.*", ] build-backend = "hatchling.build" @@ -86,7 +86,7 @@ skip-if-exists = [ "{{ cookiecutter.python_package_name }}/labextension/package.json", ] dependencies = [ - "hatch-jupyter-builder>=0.5.0", + "hatch-jupyter-builder>=0.8.2", ] [tool.hatch.build.hooks.jupyter-builder.build-kwargs] From 8a15e3a1388501381e33bceb96bdddd7dfb9d735 Mon Sep 17 00:00:00 2001 From: Ian Hunt-Isaak Date: Wed, 8 Mar 2023 17:11:35 -0500 Subject: [PATCH 2/2] update: minimum python version --- .github/workflows/build.yml | 2 +- .../.github/workflows/build.yml | 2 +- {{cookiecutter.github_project_name}}/pyproject.toml | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1f8ee6d..f618331 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -20,7 +20,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macos-latest] - python-version: ["3.7", "3.10"] + python-version: ["3.8", "3.11"] steps: - name: Checkout uses: actions/checkout@v2 diff --git a/{{cookiecutter.github_project_name}}/.github/workflows/build.yml b/{{cookiecutter.github_project_name}}/.github/workflows/build.yml index e5ce000..6e75895 100644 --- a/{{cookiecutter.github_project_name}}/.github/workflows/build.yml +++ b/{{cookiecutter.github_project_name}}/.github/workflows/build.yml @@ -13,7 +13,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macos-latest] - python-version: ["3.7", "3.10"] + python-version: ["3.8", "3.11"] steps: - name: Checkout uses: actions/checkout@v2 diff --git a/{{cookiecutter.github_project_name}}/pyproject.toml b/{{cookiecutter.github_project_name}}/pyproject.toml index c424276..277d520 100644 --- a/{{cookiecutter.github_project_name}}/pyproject.toml +++ b/{{cookiecutter.github_project_name}}/pyproject.toml @@ -10,7 +10,7 @@ name = "{{ cookiecutter.python_package_name }}" description = "{{ cookiecutter.project_short_description }}" readme = "README.md" license = { file = "LICENSE.txt" } -requires-python = ">=3.7" +requires-python = ">=3.8" authors = [ { name = "{{ cookiecutter.author_name }}", email = "{{ cookiecutter.author_email }}" }, ] @@ -26,10 +26,10 @@ classifiers = [ "License :: OSI Approved :: BSD License", "Programming Language :: Python", "Programming Language :: Python :: 3", - "Programming Language :: Python :: 3.7", "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", + "Programming Language :: Python :: 3.11", ] dependencies = [ "ipywidgets>=7.0.0",