-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the amount of data we're reading from FCstd files #26
Comments
For properties that don't have a handler, we just set their value to |
But many properties have a handler even though it's not supported by jcad ? At least that's what we see with exported files using #25 Exported files do not respect the jcad schemas so we can't open them in jupyterlite. They should respect the schemas |
These properties go into the |
I see, but why load those properties if the client can't understand them? That's probably early optimization but there are lots of properties we don't understand and it's useless to load. |
Adding a note that those unwanted data results in doubling the size of the exported ArchDetail.jcad file. |
Because JupyterCAD was designed with FCStd as a first class citizen, the idea was to eventually support them all |
Sounds good! But we should maybe add the properties we support progressively in our schema |
The method to translate a freecad object into a jcad object reads all the properties of the freecad object.
This is a bit too much because many of these properties cannot be understood by the JupyterCAD client.
We should reduce this to reading only the properties that JupyterCAD understands, making use of the Python schemas jupytercad-core now exposes.
The text was updated successfully, but these errors were encountered: