Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin jupyterlab at >=4.4.0a2,<5.0.0 in projects/jupyter-collaboration package #429

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

andrii-i
Copy link
Contributor

@andrii-i andrii-i commented Jan 16, 2025

Adds jupyterlab pin at >=4.4.0a2,<5.0.0 in projects/jupyter-collaboration subpackage. This would introduce a way to specify which versions of jupyterlab current version of jupyter-collaboration is compatible with which would prevent RTC-jupyterlab version mismatch issues for new versions of jupyter-collaboration.

Testing:

  1. Create new conda environment
  2. Install jupyterlab<4.4.0a2 by running pip install jupyterlab==4.2.0
  3. Clone this PR and install it locally by running pip install -e . from projects/jupyter-collaboration
  4. Run jupyter --version , note updated jupyterlab version

Copy link
Contributor

Binder 👈 Launch a Binder on branch andrii-i/jupyter-collaboration/pin-jlab

@andrii-i andrii-i changed the title pin jupyterlab at >=4.4.0,<5.0.0 to projects/jupyter-collaboration subpackage pin jupyterlab at >=4.4.0,<5.0.0 in projects/jupyter-collaboration subpackage Jan 16, 2025
@andrii-i andrii-i changed the title pin jupyterlab at >=4.4.0,<5.0.0 in projects/jupyter-collaboration subpackage Pin jupyterlab at >=4.4.0,<5.0.0 in projects/jupyter-collaboration subpackage Jan 16, 2025
@andrii-i andrii-i added enhancement New feature or request maintenance labels Jan 16, 2025
@andrii-i andrii-i marked this pull request as draft January 16, 2025 19:26
@andrii-i
Copy link
Contributor Author

andrii-i commented Jan 16, 2025

One open question about this PR being discussed in #425 (comment) is if platform_system!='Emscripten' should be added to the pin to account for wasm environments.

@andrii-i andrii-i requested a review from dlqqq January 16, 2025 23:16
@andrii-i andrii-i changed the title Pin jupyterlab at >=4.4.0,<5.0.0 in projects/jupyter-collaboration subpackage Pin jupyterlab at >=4.4.0a2,<5.0.0 in projects/jupyter-collaboration subpackage Jan 16, 2025
@andrii-i
Copy link
Contributor Author

Based on discussion during the JupyterLab call today adding platform_system!='Emscripten' exception is not necessary for now as there are no known jupyter-collaboration wasm environments.

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@krassowski krassowski changed the title Pin jupyterlab at >=4.4.0a2,<5.0.0 in projects/jupyter-collaboration subpackage Pin jupyterlab at >=4.4.0a2,<5.0.0 in projects/jupyter-collaboration package Jan 22, 2025
@krassowski krassowski added maintenance and removed maintenance enhancement New feature or request labels Jan 22, 2025
@krassowski
Copy link
Member

Removed "enhancement" label otherwise PRs show up twice in the changelog :)

Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@davidbrochart davidbrochart merged commit bd4b23a into jupyterlab:main Jan 23, 2025
38 checks passed
@andrii-i andrii-i deleted the pin-jlab branch January 23, 2025 16:04
@andrii-i
Copy link
Contributor Author

Thank you everyone for looking into this 🚀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should most collaboration python packages depend on jupyterlab?
4 participants