Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortening the failed link output #29

Open
AnnaDinaburgVulikh opened this issue Nov 12, 2020 · 6 comments
Open

Shortening the failed link output #29

AnnaDinaburgVulikh opened this issue Nov 12, 2020 · 6 comments

Comments

@AnnaDinaburgVulikh
Copy link
Contributor

Hi, when a failed link is found a short log of the failed link is shown but after that comes a very long log of all the functions that failed in the process.

Would be happy to help with the fix if you can point me in the right direction.

@AnnaDinaburgVulikh
Copy link
Contributor Author

@blink1073 can you give me some pointers for fixing this?

@afshin
Copy link
Member

afshin commented Nov 16, 2020

Is this a byproduct of the native stack traces in Python?

I am not sure how to resolve this in a way that doesn't obscure information needed to debug.

@AnnaDinaburgVulikh
Copy link
Contributor Author

AnnaDinaburgVulikh commented Nov 16, 2020

It's odd, but I couldn't reproduce this on my machine right now.
When I opened this issue I got an error for some links and an output of all the functions the project uses to check the links.
Ran it 3 times right now and everything looks OK.

@AnnaDinaburgVulikh
Copy link
Contributor Author

AnnaDinaburgVulikh commented Nov 29, 2020

@afshin , got the long log again, you can see it below.
Tried the site manually, everything seems to work, but the test fails.
Can you help?

link-error.log

@afshin
Copy link
Member

afshin commented Nov 29, 2020

I am not sure what is happening @AnnaDinaburgVulikh, but I wonder if it has to do with the fact that that URL is a 2.1 megabyte download ... which might explain the intermittent nature of the failure. It's a very large HTML file because it has images that are base64 encoded and included as data URLs for image tags within the file.

@AnnaDinaburgVulikh
Copy link
Contributor Author

As I see it, there are 2 questions inferred :

  1. Is all the log relevant, or it might be shorter ? If so, where can I tackle it.
  2. Is there a way to override the default timeout?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants