-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of messages #29
Comments
The providers could also be improved by adding some context, like the existing code (in the cell, in the Notebook...). |
Indeed. Maybe that's something langchain can make easier to work with (would need to double check). |
Also, it looks like the current use of |
Yes, the idea was to let the AI complete the sentence as if it had started it (I may have read that hack somewhere but can't find it again). Indeed, with more context in an initial |
Problem
Currently it looks like some providers recreate a list of messages for each completion request, for example:
ai/src/llm-models/anthropic-completer.ts
Lines 30 to 35 in ba99ad6
Should be persisted per provider instead?
Proposed Solution
Should this list of messages be shared across providers? Or should it be reset when a user switches to another provider?
Maybe a reset would be fine to keep things tidy. Also users probably wouldn't change providers often in practice?
Additional context
This would also be relevant to other providers like #27.
The text was updated successfully, but these errors were encountered: