From fca2b2bcd2fed17f1c844fb002dd3105d6d87b76 Mon Sep 17 00:00:00 2001 From: Jake Moxey Date: Sun, 9 Aug 2020 22:13:13 +1000 Subject: [PATCH] Add hideOnClick prop to DropdownMenuItem --- packages/bumbag/src/DropdownMenu/DropdownMenuItem.tsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/bumbag/src/DropdownMenu/DropdownMenuItem.tsx b/packages/bumbag/src/DropdownMenu/DropdownMenuItem.tsx index a4b98e00c..6c660b937 100644 --- a/packages/bumbag/src/DropdownMenu/DropdownMenuItem.tsx +++ b/packages/bumbag/src/DropdownMenu/DropdownMenuItem.tsx @@ -9,6 +9,7 @@ import { DropdownMenuContext } from './DropdownMenu'; import * as styles from './styles'; export type LocalDropdownMenuItemProps = { + hideOnClick?: boolean; /** Icon that appears on the right side of the menu item. */ iconAfter?: IconProps['icon']; iconAfterProps?: Omit; @@ -37,6 +38,7 @@ const useProps = createHook( registerItem, currentId, hide, + hideOnClick, move, next, onClick, @@ -126,11 +128,11 @@ const useProps = createHook( {iconAfter && } ), - onClick: bindFns(onClick, hide, dropdownMenu.hide), + onClick: hideOnClick ? bindFns(onClick, hide, dropdownMenu.hide) : onClick, tabIndex: props.isTabbable ? boxProps.tabIndex : undefined, }; }, - { defaultProps: { isTabbable: true }, themeKey: 'DropdownMenu.Item' } + { defaultProps: { hideOnClick: true, isTabbable: true }, themeKey: 'DropdownMenu.Item' } ); export const DropdownMenuItem = createComponent(