Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Styling DropdownMenu.Popover and :not(:disabled):hover #87

Open
b-gibbs opened this issue Nov 25, 2020 · 0 comments
Open

Styling DropdownMenu.Popover and :not(:disabled):hover #87

b-gibbs opened this issue Nov 25, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@b-gibbs
Copy link

b-gibbs commented Nov 25, 2020

Is your feature request related to a problem? Please describe.

Since this works:

  const DDMenu = applyTheme(DropdownMenu, {
    Popover: {
      modes: {
        dark: {
          styles: {
            base: {
              backgroundColor: "#2f3747"
            }
          }
        }
      }
    },

it feels like this should be possible in ThemeConfig:

  DropdownMenu: {
    Popover: {
      modes: {
        dark: {
          styles: {
            base: {
              backgroundColor: "#2f3747"
            }
          }
        }
      }
    }
  },

But it isn't.

Also, I'd like to be able to change the backgroundColor of a DropdownMenu.Item, but _hover is superseded by :not(:diabled):hover and I don't see anything in the API to override that.

Describe the solution you'd like

I'd like to be able to customize colors on a mode basis within ThemeConfig without overriding the default palette. I like the default palette, but feel that the backgrounds of the dropdown menus should stand out more from the background color of the rest of the page.

Describe alternatives you've considered

Just about every combination of things TypeScript will allow.

It's entirely possible that this is user error. If so, I'd ask that the documentation on theming be updated to include examples of nested components.

@jxom jxom added enhancement New feature or request good first issue Good for newcomers labels Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants