Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into CSS build ordering issue #155

Closed
marcianosr opened this issue Nov 24, 2023 · 2 comments · Fixed by #158
Closed

Look into CSS build ordering issue #155

marcianosr opened this issue Nov 24, 2023 · 2 comments · Fixed by #158

Comments

@marcianosr
Copy link
Contributor

marcianosr commented Nov 24, 2023

On staging / production, the CSS build ordering seems to be going wrong, resulting in weird CSS specificity issues causing wrong styling on certain places.

Temporary fixes are:

@sandercamp
Copy link
Contributor

Some background info: the ui-components package outputs all styling to separate css files that are injected in the html head when building for production. This is standard behavior from rollup + postcss plugin, which sucks. React-scripts puts it output above these stylesheets, hence causing issues with specificity.

I think a quick solution would be to configure the ui-components package so it outputs styling as a single css file that we can than include/import at the correct location.

@sandercamp
Copy link
Contributor

First draft looks to be working: #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants