Skip to content

Commit 3cf4683

Browse files
committed
wip: Enhance collection filtering #1151
style: linted code
1 parent 5e79eb5 commit 3cf4683

File tree

8 files changed

+42
-13
lines changed

8 files changed

+42
-13
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<template>
2+
<div class="column">
3+
<div class="row justify-center">
4+
<KTimeFilterView />
5+
</div>
6+
<div class="row justify-center">
7+
<KTagsFilterView />
8+
</div>
9+
</div>
10+
</template>
11+
12+
<script setup>
13+
import KTimeFilterView from './KTimeFilterView.vue'
14+
import KTagsFilterView from './KTagsFilterView.vue'
15+
</script>

core/client/components/collection/KSearchFilter.vue core/client/components/collection/KSearchFilterControl.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<div class="q-pa-xs" :style="innerStyle">
2+
<div class="q-pa-xs">
33
<!--
44
Input area
55
-->
@@ -64,7 +64,7 @@
6464
<script setup>
6565
import _ from 'lodash'
6666
import { ref, computed } from 'vue'
67-
import { useCurrentActivity } from '../../composables'
67+
import { useCurrentActivity } from '../../composables/index.js'
6868
import { Search } from '../../search.js'
6969
7070
// Props

core/client/components/action/KTagsFilterAction.vue core/client/components/collection/KTagsFilterControl.vue

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
<div>
33
<q-fab
44
v-if="hasOptions"
5+
id="tags-filter-control"
56
icon="las la-filter"
67
color="grey-9"
78
flat
@@ -23,7 +24,7 @@
2324
</template>
2425
</q-fab>
2526
<q-tooltip v-if="enableTooltip">
26-
{{ $t('C3XTagsFilterAction.FILTER') }}
27+
{{ $t('KTagsFilterControl.FILTER') }}
2728
</q-tooltip>
2829
</div>
2930
</template>

core/client/components/action/KTimeFilterAction.vue core/client/components/collection/KTimeFilterControl.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<template>
22
<KAction
33
v-if="hasTimeRange"
4-
id="time-filter-action"
4+
id="time-filter-control"
55
icon="las la-clock"
6-
tooltip="C3XTimeFilterAction.FILTER"
6+
tooltip="KTimeFilterControl.FILTER"
77
:handler="showTimeRangeSlider"
88
/>
99
</template>

core/client/components/collection/KTimeFilterView.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<template>
22
<div v-if="hasSelection"
3-
class="q-px-sm q-py-xs row items-center q-gutter-x-sm k-time-filter no-wrap"
3+
class="q-px-sm q-py-xs row items-center q-gutter-x-sm no-wrap k-time-filter"
44
style="width: 800px; max-width: 90vw"
55
>
66
<KDateTimeRange

core/client/i18n/core_en.json

+6
Original file line numberDiff line numberDiff line change
@@ -694,6 +694,12 @@
694694
"KFilter": {
695695
"SEARCH_LABEL": "@:SEARCH"
696696
},
697+
"KTagsFilterControl": {
698+
"FILTER": "Filter by properties"
699+
},
700+
"KTimeFilterControl": {
701+
"FILTER": "Filter by time"
702+
},
697703
"KTextArea": {
698704
"COLLAPSE": "Collapse"
699705
},

core/client/i18n/core_fr.json

+6
Original file line numberDiff line numberDiff line change
@@ -691,6 +691,12 @@
691691
"KFilter": {
692692
"SEARCH_LABEL": "@:SEARCH"
693693
},
694+
"KTagsFilterControl": {
695+
"FILTER": "Filtrer selon les propriétés"
696+
},
697+
"KTimeFilterControl": {
698+
"FILTER": "Filtrer selon le temps"
699+
},
694700
"KTextArea": {
695701
"COLLAPSE": "Réduire"
696702
},

map/client/components/stickies/KLevelSlider.vue

+8-7
Original file line numberDiff line numberDiff line change
@@ -3,26 +3,27 @@
33
class="k-level-slider flex items-baseline justify-center bg-white q-px-sm q-py-md">
44
<p v-if="props.switchLabelSide" class="text-accent text-caption no-margin"
55
style="writing-mode: vertical-lr; transform-origin: center; transform: rotate(180deg);">
6-
<b>{{ $t(CurrentActivity.selectableLevels.label) }} - {{ getFormatedLevel(CurrentActivity.selectedLevel) }}</b>
6+
<b>{{ $t(CurrentActivity.selectableLevels.label) }} - {{ getFormattedLevel(CurrentActivity.selectedLevel) }}</b>
77
</p>
88
<q-slider v-if="dataArray" snap class="text-primary" v-model="sliderVal" :vertical="props.vertical"
99
:reverse="props.reverse ?? props.vertical" :height="150" :width="4" :markers="props.markers" :label-always="false"
10-
:max="dataArray.length - 1" label :label-value="getFormatedLevel(dataArray[sliderVal])"
10+
:max="dataArray.length - 1" label :label-value="getFormattedLevel(dataArray[sliderVal])"
1111
:switch-label-side="props.switchLabelSide ? !props.switchLabelSide : props.vertical" @change="onLevelChanged" />
1212
<q-slider v-else class="text-primary" :model-value="sliderVal" :vertical="props.vertical"
1313
:reverse="props.reverse ?? props.vertical" :height="150" :width="4" :markers="props.markers" :label-always="false"
1414
:min="sliderMinValue" :max="sliderMaxValue" :step="sliderInterval" label
15-
:label-value="getFormatedLevel(sliderVal)"
15+
:label-value="getFormattedLevel(sliderVal)"
1616
:switch-label-side="props.switchLabelSide ? !props.switchLabelSide : props.vertical" @change="onLevelChanged"
1717
@update:model-value="val => sliderVal = val" />
1818
<p v-if="!props.switchLabelSide" class="text-accent text-caption no-margin"
1919
style="writing-mode: vertical-lr; transform-origin: center; transform: rotate(180deg);">
20-
<b>{{ $t(CurrentActivity.selectableLevels.label) }} - {{ getFormatedLevel(CurrentActivity.selectedLevel) }}</b>
20+
<b>{{ $t(CurrentActivity.selectableLevels.label) }} - {{ getFormattedLevel(CurrentActivity.selectedLevel) }}</b>
2121
</p>
2222
</div>
2323
</template>
2424

2525
<script setup>
26+
import _ from 'lodash'
2627
import { computed, ref } from 'vue'
2728
import { useCurrentActivity } from '../../../../core/client/composables'
2829
@@ -54,7 +55,7 @@ const props = defineProps({
5455
const { CurrentActivity } = useCurrentActivity()
5556
const sliderVal = ref(0)
5657
57-
// ==COMPUTED==
58+
// Computed
5859
const isVisible = computed(() => sliderValues.value ? sliderValues.value.length > 0 : (sliderMinValue.value !== undefined && sliderMaxValue.value !== undefined))
5960
// const isLazy = computed(() => _.get(CurrentActivity.value.selectableLevels, 'lazy', true))
6061
const sliderValues = computed(() => _.get(CurrentActivity.value.selectableLevels, 'values'))
@@ -63,15 +64,15 @@ const sliderMinValue = computed(() => _.get(CurrentActivity.value.selectableLeve
6364
const sliderMaxValue = computed(() => _.get(CurrentActivity.value.selectableLevels, 'range.max'))
6465
const sliderInterval = computed(() => _.get(CurrentActivity.value.selectableLevels, 'range.interval', 1))
6566
66-
// ==MISC FUNCTIONS==
67+
// Functions
6768
function onLevelChanged (level) {
6869
if (dataArray.value) {
6970
CurrentActivity.value.setSelectedLevel(dataArray.value[level])
7071
} else {
7172
CurrentActivity.value.setSelectedLevel(level)
7273
}
7374
}
74-
function getFormatedLevel (level) {
75+
function getFormattedLevel (level) {
7576
const unit = _.get(CurrentActivity.value.selectableLevels, 'unit')
7677
return `${level || CurrentActivity.value.selectedLevel} ${unit}`
7778
}

0 commit comments

Comments
 (0)