Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lints are broken on Zed Preview 0.175.3 #11

Closed
rosingrind opened this issue Feb 24, 2025 · 1 comment
Closed

Lints are broken on Zed Preview 0.175.3 #11

rosingrind opened this issue Feb 24, 2025 · 1 comment

Comments

@rosingrind
Copy link

After zed-industries/zed#25054 was merged, I tried to check if #2 is still an issue.
When I open any Ansible file, ansible-lint spins up and I see lint warnings/errors in editor for a fraction of time, but they are instantly gone. Sometimes they are presented for a single frame, sometimes you don't even get a chance to see them. LSP logs are reporting that ansible-lint is fired up twice:

Path for lint: /Users/beno/.pyenv/shims/ansible-lint
Validating using ansible-lint
Path for lint: /Users/beno/.pyenv/shims/ansible-lint
Validating using ansible-lint

My Zed config contains this:

{
  "file_types": {
    "Jinja2": ["jinja", "jinja2", "j2"],
    "Ansible": [
      "**.ansible.yml",
      "**.ansible.yaml",
      "**/defaults/*.yml",
      "**/defaults/*.yaml",
      "**/meta/*.yml",
      "**/meta/*.yaml",
      "**/tasks/*.yml",
      "**/tasks/*.yml",
      "**/tasks/*.yaml",
      "**/handlers/*.yml",
      "**/handlers/*.yaml",
      "**/group_vars/*.yml",
      "**/group_vars/*.yaml",
      "**/playbooks/*.yaml",
      "**/playbooks/*.yml",
      "**playbook*.yaml",
      "**playbook*.yml"
    ]
  },
  "languages": {
    "YAML": {
      "language_servers": ["ansible", "ansible-lint"],
      "tab_size": 2,
      "formatter": "language_server",
      "format_on_save": "on"
    }
  },
  "lsp": {
    "ansible-language-server": {
      "settings": {
        "ansible": {
          "path": "ansible"
        },
        "executionEnvironment": {
          "enabled": false
        },
        "python": {
          "interpreterPath": "python3"
        },
        "validation": {
          "enabled": true,
          "lint": {
            "enabled": true,
            "path": "ansible-lint",
            "arguments": "--skip-list=yaml[indentation],yaml[line-length],fqcn[action],fqcn[action-core],name[play]"
          }
        }
      }
    }
  }
}
@kartikvashistha
Copy link
Owner

Hi @rosingrind - thank you for reporting this!

I had observed the same this past weekend, and as such have filed an issue upstream for this. Since this is an issue with upstream and it has been filed with them, I'll close this issue in favour of that one.

Please give the upstream issue a thumbs up and bump it with any other useful information that I may have missed in order for the team to prioritize this regression.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants