Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Don't require reviewers approval for the release PRs #245

Open
fidencio opened this issue Nov 23, 2021 · 1 comment
Open

release: Don't require reviewers approval for the release PRs #245

fidencio opened this issue Nov 23, 2021 · 1 comment

Comments

@fidencio
Copy link
Member

Anyone who has spent time doing releases has figured out that the process is time consuming, and one of the things that makes this more time consuming is having to find someone to review two PRs that are automatically generated and contain exactly what we expect from our scripts.

With this in mind, I really would like to ask whether we could have an agreement on the person who's handling the release merging the PRs without the need of the reviews, as long as the CIs and /test_kata_deploy are successful.

/cc @kata-containers/architecture-committee

@fidencio fidencio transferred this issue from kata-containers/kata-containers Nov 23, 2021
@jodh-intel
Copy link
Contributor

Thanks for raising this @fidencio. I'm sure we'd all prefer some manual reviews and acks but if the (global!) community are not able to react in a timely enough manner, we have to consider alternatives and this sounds like a pragmatic one.

Can you send a mail to the ML and add this to the AC meeting agenda so everyone is clear on this proposal:

If release PRs are not reviewed in a timely fashion (< 1 hour I'd say, but ideally even quicker), we are going to be forced to not require acks and automate the releases...

For reference, the release documentation is here:

/cc those who have been involved in release work in the past to get their input on the plan: @amshinde, @chavafg, @jcvenegas, @egernst, @bergwolf , @bpradipt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants