Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime: pass correct parameters for tap0_kata macvtap with acrn-dm to launch acrn vm #398

Closed
hongzhanchen opened this issue Apr 28, 2024 · 1 comment

Comments

@hongzhanchen
Copy link

According to https://projectacrn.github.io/3.0/developer-guides/hld/virtio-net.html, we may need to pass tap=tap0_kata for macvtap but currently it just pass like virtio-net ,tap0-kata,mac=**** which is not recognized by acrn.

patch:

diff --git a/src/runtime/virtcontainers/acrn_arch_base.go b/src/runtime/virtcontainers/acrn_arch_base.go
index fa8ce0fe6..278c76045 100644
--- a/src/runtime/virtcontainers/acrn_arch_base.go
+++ b/src/runtime/virtcontainers/acrn_arch_base.go
@@ -426,7 +426,7 @@ func (netdev NetDevice) AcrnNetdevParam() []string {
deviceParams = append(deviceParams, netdev.IFName)
deviceParams = append(deviceParams, fmt.Sprintf(",mac=%s", netdev.MACAddress))
case MACVTAP:

  •           deviceParams = append(deviceParams, netdev.IFName)
    
  •           deviceParams = append(deviceParams, fmt.Sprintf("tap=%s", netdev.IFName))
              deviceParams = append(deviceParams, fmt.Sprintf(",mac=%s", netdev.MACAddress))
      default:
              deviceParams = append(deviceParams, netdev.IFName)
    
@hongzhanchen
Copy link
Author

Sorry , submit wrong place for the issue. I already filed new one on kata-containers repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To do
Development

No branches or pull requests

1 participant