Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues fix #18

Closed
wants to merge 2 commits into from
Closed

Issues fix #18

wants to merge 2 commits into from

Conversation

gephaistos
Copy link

Closes #14 and #11.
SB and UJ immediate value is represented as described in RISCV specification (p.12, fig. 2.4).
For sanity check this online compiler was used.

@kcelebi
Copy link
Owner

kcelebi commented Apr 11, 2023

Thank you for this PR. Unfortunately, this only works for the deprecated version of the package and these issues have already been fixed.

Note: I won't be updating this repository anymore as it has been moved to celebi-pkg/riscv-assembler. The Python deployments and latest code are being updated there.

@kcelebi kcelebi closed this Apr 11, 2023
@gephaistos
Copy link
Author

Thank you for this PR. Unfortunately, this only works for the deprecated version of the package and these issues have already been fixed.

Note: I won't be updating this repository anymore as it has been moved to celebi-pkg/riscv-assembler. The Python deployments and latest code are being updated there.

Got it.
Since that, maybe the links should be updated as well for the new project? Published package on PyPI still links to the old repo homepage, changelog etc.

@kcelebi
Copy link
Owner

kcelebi commented Apr 24, 2023

Got it. Since that, maybe the links should be updated as well for the new project? Published package on PyPI still links to the old repo homepage, changelog etc.

Good call! Fixing this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative jump addresses calculated incorrectly
2 participants