Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New ScalingSet CRD to deploy isolated interceptors+scalers #703

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kahirokunn
Copy link

@kahirokunn kahirokunn commented Nov 7, 2024

Provide a description of what has been changed

kedacore/http-add-on#1014

Checklist

Fixes #

@Farfaday
Copy link
Contributor

Please add the crds.additionalAnnotations to the new CRDs.
By copying this block for example: https://github.com/kedacore/charts/blob/main/keda/templates/crds/crd-scaledjobs.yaml#L7
Thanks!

@kahirokunn kahirokunn force-pushed the New-ScalingSet-CRD branch 3 times, most recently from fd0b26f to 7b27f2b Compare November 20, 2024 12:28
@kahirokunn
Copy link
Author

@Farfaday Thank you for your review! I have implemented all of the points you raised in your review.

@imdmahajankanika
Copy link

Hello! Is this feature about creating interceptor svc in the same namespace as application rather than KEDA namespace?

@kahirokunn
Copy link
Author

Yes, that's correct! This feature allows for creating an interceptor service in the same namespace as the application. Additionally, it also supports creating a shared interceptor service if desired.

@imdmahajankanika
Copy link

Yes, that's correct! This feature allows for creating an interceptor service in the same namespace as the application. Additionally, it also supports creating a shared interceptor service if desired.

Thanks! So that means, instead of creating a service of type external name for interceptor service in the application namespace, I can directly connect ingress to the interceptor service in the application namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants