Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kedro-datasets: Datasets accept non-primitive parameters in the __init__ #950

Open
ElenaKhaustova opened this issue Nov 27, 2024 · 0 comments
Labels
datasets enhancement New feature or request

Comments

@ElenaKhaustova
Copy link
Contributor

ElenaKhaustova commented Nov 27, 2024

Description

Catalog to config solution is based on extracting dataset __init__ parameters and their values passed when creating a dataset.

The solution does not cover the case when non-primitive parameters are accepted in the dataset constructor:

Possible Implementation

(Preferable solution) Force datasets to only have static, primitive parameters in the __init__: kedro-org/kedro#4329 (comment)

Possible Alternatives

Extend parent AbstractDataset.to_config() at the dataset level to serialize those objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant