You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#957 made CI run with Polars 1.x, but CSVDatasets doesn't seem to be working on Windows—the doctest and unit tests that call save are all failing.
Since #957 didn't really change this functionality (which is why I xfailed the tests to unblock), it's worth making sure this stuff actually works on Windows.
Steps to Reproduce
Try to follow the test or doctest logic on Windows.
Expected Result
Tell us what should happen.
Actual Result
From the CI:
@wraps(save_func)defsave(self: Self, data: _DI) ->None:
ifdataisNone:
raiseDatasetError("Saving 'None' to a 'Dataset' is not allowed")
try:
self._logger.debug("Saving %s", str(self))
save_func(self, data)
except (DatasetError, FileNotFoundError, NotADirectoryError):
raiseexceptExceptionasexc:
message=f"Failed while saving data to dataset {self!s}.\n{exc!s}">raiseDatasetError(message) fromexcEkedro.io.core.DatasetError: FailedwhilesavingdatatodatasetCSVDataset(filepath=C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-1/popen-gw1/test_versioning_existing_datas11/test.csv, load_args={'rechunk': True}, protocol=file, save_args={}).
EfileencodingisnotUTF-8
(Doctest fails with the reloaded variable just not getting assigned, which may very well be related.)
Description
#957 made CI run with Polars 1.x, but
CSVDatasets
doesn't seem to be working on Windows—the doctest and unit tests that callsave
are all failing.Since #957 didn't really change this functionality (which is why I xfailed the tests to unblock), it's worth making sure this stuff actually works on Windows.
Steps to Reproduce
Try to follow the test or doctest logic on Windows.
Expected Result
Tell us what should happen.
Actual Result
From the CI:
(Doctest fails with the
reloaded
variable just not getting assigned, which may very well be related.)Your Environment
Windows CI; see https://github.com/kedro-org/kedro-plugins/actions/runs/12187331556/job/34016095791
The text was updated successfully, but these errors were encountered: