fix(datasets): unpin pandas-gbq #758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felipe Monroy <[email protected]>
|
@astrojuanlu @noklam could you review it please? |
|
It was a while ago and we haven't updated the pin since then. Thanks for raising the PR. |
noklam
reviewed
Jul 11, 2024
Co-authored-by: Nok Lam Chan <[email protected]> Signed-off-by: Felipe Monroy <[email protected]>
|
Hey @felipemonroy , do you still intend to pursue this PR? |
|
Hi @astrojuanlu. After rebase my tests were failing because of #755 . I had to make #773 because of that. My git flow was a mess so I forked the repo again (and lost all the previous changes). I am going to create the PR again tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More recent versions of pandas does not work with
pandas-gbq<0.18.0, which was set forpython < 3.11Development notes
Not sure why the restriction was there
Checklist
RELEASE.mdfile