-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datasets): Replace deprecated GBQDataset load/save funcs #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: janick_spirig <[email protected]>
Signed-off-by: janick_spirig <[email protected]>
janickspirig
changed the title
fix(pandas-gbq)
fix(datasets): Relace deprecated GBQDataset load/save funcs
Sep 7, 2024
janickspirig
changed the title
fix(datasets): Relace deprecated GBQDataset load/save funcs
fix(datasets): Replace deprecated GBQDataset load/save funcs
Sep 7, 2024
Signed-off-by: janick_spirig <[email protected]>
Signed-off-by: janick_spirig <[email protected]>
Signed-off-by: janick_spirig <[email protected]>
merelcht
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution @janickspirig ⭐ 👍
ankatiyar
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
harm-matthias-harms
pushed a commit
to harm-matthias-harms/kedro-plugins
that referenced
this pull request
Oct 1, 2024
…rg#826) * fix:use_pd_gbq Signed-off-by: janick_spirig <[email protected]> * fix:updated_readme Signed-off-by: janick_spirig <[email protected]> * fix:updated_args Signed-off-by: janick_spirig <[email protected]> * fix:updated_args_in_test Signed-off-by: janick_spirig <[email protected]> * fix:linting Signed-off-by: janick_spirig <[email protected]> --------- Signed-off-by: janick_spirig <[email protected]> Co-authored-by: Merel Theisen <[email protected]> Co-authored-by: Ankita Katiyar <[email protected]> Signed-off-by: Harm Matthias Harms <[email protected]>
MinuraPunchihewa
pushed a commit
to MinuraPunchihewa/kedro-plugins
that referenced
this pull request
Oct 1, 2024
…rg#826) * fix:use_pd_gbq Signed-off-by: janick_spirig <[email protected]> * fix:updated_readme Signed-off-by: janick_spirig <[email protected]> * fix:updated_args Signed-off-by: janick_spirig <[email protected]> * fix:updated_args_in_test Signed-off-by: janick_spirig <[email protected]> * fix:linting Signed-off-by: janick_spirig <[email protected]> --------- Signed-off-by: janick_spirig <[email protected]> Co-authored-by: Merel Theisen <[email protected]> Co-authored-by: Ankita Katiyar <[email protected]> Signed-off-by: Minura Punchihewa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR addresses #825
Development notes
Adjusted read/write to use
.to_gbq()
and.read_gbq()
directly from pandas-gbq package (pd_gbq
) to avoid deprecation warningsChecklist
RELEASE.md
file