Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasets): Replace deprecated GBQDataset load/save funcs #826

Merged
merged 8 commits into from
Sep 26, 2024

Conversation

janickspirig
Copy link
Contributor

@janickspirig janickspirig commented Sep 7, 2024

Description

PR addresses #825

Development notes

Adjusted read/write to use .to_gbq() and .read_gbq() directly from pandas-gbq package (pd_gbq) to avoid deprecation warnings

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: janick_spirig <[email protected]>
@janickspirig janickspirig changed the title fix:use_pd_gbq fix(pandas-gbq) Sep 7, 2024
Signed-off-by: janick_spirig <[email protected]>
@janickspirig janickspirig changed the title fix(pandas-gbq) fix(datasets): Relace deprecated GBQDataset load/save funcs Sep 7, 2024
@janickspirig janickspirig changed the title fix(datasets): Relace deprecated GBQDataset load/save funcs fix(datasets): Replace deprecated GBQDataset load/save funcs Sep 7, 2024
Signed-off-by: janick_spirig <[email protected]>
Signed-off-by: janick_spirig <[email protected]>
Signed-off-by: janick_spirig <[email protected]>
@janickspirig janickspirig marked this pull request as ready for review September 7, 2024 21:22
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @janickspirig ⭐ 👍

Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ankatiyar ankatiyar enabled auto-merge (squash) September 25, 2024 15:14
@ankatiyar ankatiyar merged commit 06cf752 into kedro-org:main Sep 26, 2024
14 checks passed
harm-matthias-harms pushed a commit to harm-matthias-harms/kedro-plugins that referenced this pull request Oct 1, 2024
…rg#826)

* fix:use_pd_gbq

Signed-off-by: janick_spirig <[email protected]>

* fix:updated_readme

Signed-off-by: janick_spirig <[email protected]>

* fix:updated_args

Signed-off-by: janick_spirig <[email protected]>

* fix:updated_args_in_test

Signed-off-by: janick_spirig <[email protected]>

* fix:linting

Signed-off-by: janick_spirig <[email protected]>

---------

Signed-off-by: janick_spirig <[email protected]>
Co-authored-by: Merel Theisen <[email protected]>
Co-authored-by: Ankita Katiyar <[email protected]>
Signed-off-by: Harm Matthias Harms <[email protected]>
MinuraPunchihewa pushed a commit to MinuraPunchihewa/kedro-plugins that referenced this pull request Oct 1, 2024
…rg#826)

* fix:use_pd_gbq

Signed-off-by: janick_spirig <[email protected]>

* fix:updated_readme

Signed-off-by: janick_spirig <[email protected]>

* fix:updated_args

Signed-off-by: janick_spirig <[email protected]>

* fix:updated_args_in_test

Signed-off-by: janick_spirig <[email protected]>

* fix:linting

Signed-off-by: janick_spirig <[email protected]>

---------

Signed-off-by: janick_spirig <[email protected]>
Co-authored-by: Merel Theisen <[email protected]>
Co-authored-by: Ankita Katiyar <[email protected]>
Signed-off-by: Minura Punchihewa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants