You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
kedro-starters currently does not have a make lint command on its Makefile, and all of the checks for linting is done on the e2e-tests. This causes some issues when working on the repo, as linter errors are found only when changes are pushed to remote.
Context
Adding a linting option do be used while developing on the kedro-starters repo would make it easier to fix linter errors without having to run e2e tests locally and then go through each one of the errors manually, or only find out about them when the changes are going through CI.
Possible Implementation
The challenge with linting this repo is that ruff, which is what is being used on the e2e-tests, will break on the cookiecutter placeholders. The linting on CI is done on projects built from the templates, and not on the templates themselves:
The most straightforward option would be to use a command like ruff check --fix --exit-zero, which will still fix errors if fixable, and will not stop on the parsing errors above. It will still display the parsing errors, though.
The text was updated successfully, but these errors were encountered:
Description
kedro-starters
currently does not have amake lint
command on its Makefile, and all of the checks for linting is done on the e2e-tests. This causes some issues when working on the repo, as linter errors are found only when changes are pushed to remote.Context
Adding a linting option do be used while developing on the
kedro-starters
repo would make it easier to fix linter errors without having to run e2e tests locally and then go through each one of the errors manually, or only find out about them when the changes are going through CI.Possible Implementation
The challenge with linting this repo is that ruff, which is what is being used on the e2e-tests, will break on the cookiecutter placeholders. The linting on CI is done on projects built from the templates, and not on the templates themselves:
The most straightforward option would be to use a command like
ruff check --fix --exit-zero
, which will still fix errors if fixable, and will not stop on the parsing errors above. It will still display the parsing errors, though.The text was updated successfully, but these errors were encountered: