-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update isRunningLocally
Function to Recognise Private IP Addresses for Consistent GUI Rendering
#2223
Update isRunningLocally
Function to Recognise Private IP Addresses for Consistent GUI Rendering
#2223
Conversation
Signed-off-by: Sajid Alam <[email protected]>
hey thanks @SajidAlamQB just a quick reminder to add this in the release note, and also can you also put a few notes in the QA steps please, eg: is there anything we should run locally to test this specifically? |
I've added it in the description: Run Kedro-Viz:
Local Access via IP:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SajidAlamQB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @SajidAlamQB
Co-authored-by: Jitendra Gundaniya <[email protected]> Signed-off-by: Sajid Alam <[email protected]>
Description
Related to: #2198
This PR addresses an issue where Kedro-Viz does not display the full GUI when accessed via local private IP addresses (e.g., 192.168.x.x). We will update the
isRunningLocally
function to include private IP ranges defined in RFC 1918, to ensure consistent GUI rendering when accessing Kedro-Viz on local networks.Development notes
Regular expressions have been added to match the following private IP ranges:
QA Notes
Local Access via localhost:
Run Kedro-Viz:
kedro viz run --host=0.0.0.0 --port=1008
Local Access via IP:
Checklist
RELEASE.md
file