Design question on kedro.runners

[astrojuanlu]

I tried to quickly look into what would be the root cause of #3985 just by reading the code, and I could not find it. However, I did find that some code in kedro.runners depends on kedro.framework:

kedro/kedro/runner/runner.py

Line 23 in c269cde

from kedro.framework.hooks.manager import _NullPluginManager

That looks like a smell to me - if anything, kedro.framework should import the rest of the library components and not the other way around?

[astrojuanlu]

And also - just noticed that runner.run accepts a hook_manager. Looks like the responsibilities of invoking the hooks are split between the Runner and the KedroSession:

kedro/kedro/framework/session/session.py

Lines 394 to 413 in c269cde

	try:
	run_result = runner.run(
	filtered_pipeline, catalog, hook_manager, session_id
	)
	self._run_called = True
	except Exception as error:
	hook_manager.hook.on_pipeline_error(
	error=error,
	run_params=record_data,
	pipeline=filtered_pipeline,
	catalog=catalog,
	)
	raise
	hook_manager.hook.after_pipeline_run(
	run_params=record_data,
	run_result=run_result,
	pipeline=filtered_pipeline,
	catalog=catalog,
	)