Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checkout branch check when not an official starter #4389

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove checkout branch check when not an official starter #4389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a45382
Remove branch check when not a starter
ankatiyar Dec 23, 2024
2b8e9ad
fix docslink + tests
ankatiyar Dec 23, 2024
afeef40
fix docslink + tests
ankatiyar Dec 23, 2024
3eae2ea
no cover
ankatiyar Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/source/deployment/databricks/databricks_deployment_workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,8 @@ The Databricks API enables you to programmatically interact with Databricks serv

1. [Set up your Kedro project for deployment on Databricks](#set-up-your-project-for-deployment-to-databricks)
2. Create a JSON file containing your job's configuration.
3. Use the Jobs API's [`/create` endpoint](https://docs.databricks.com/workflows/jobs/jobs-api-updates.html#create) to create a new job.
4. Use the Jobs API's [`/runs/submit` endpoint](https://docs.databricks.com/workflows/jobs/jobs-api-updates.html#runs-submit) to run your newly created job.
3. Use the Jobs API's [`/create` endpoint](https://docs.databricks.com/en/reference/jobs-2.0-api.html#create) to create a new job.
4. Use the Jobs API's [`/runs/submit` endpoint](https://docs.databricks.com/en/reference/jobs-2.0-api.html#runs-submit) to run your newly created job.

### How to use the Databricks CLI to automatically deploy a Kedro project

Expand Down
3 changes: 1 addition & 2 deletions kedro/framework/cli/starters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,6 @@ def new( # noqa: PLR0913
checkout = _select_checkout_branch_for_cookiecutter(checkout)
elif starter_alias is not None:
template_path = starter_alias
checkout = _select_checkout_branch_for_cookiecutter(checkout)
else:
template_path = str(TEMPLATE_PATH)

Expand Down Expand Up @@ -520,7 +519,7 @@ def _get_available_tags(template_path: str) -> list:
# tags: ['/tags/version', '/tags/version^{}']
# unique_tags: {'version'}

except git.GitCommandError:
except git.GitCommandError: # pragma: no cover
return []
return sorted(unique_tags)

Expand Down
6 changes: 0 additions & 6 deletions tests/framework/cli/test_starters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,9 +861,6 @@ def test_git_repo(self, fake_kedro_cli, mock_determine_repo_dir, mock_cookiecutt
"template": "git+https://github.com/fake/fake.git",
"directory": None,
}
starters_version = mock_determine_repo_dir.call_args[1].pop("checkout", None)

assert starters_version in [version, "main"]
assert kwargs.items() <= mock_determine_repo_dir.call_args[1].items()
del kwargs["directory"]
assert kwargs.items() <= mock_cookiecutter.call_args[1].items()
Expand Down Expand Up @@ -910,9 +907,6 @@ def test_git_repo_custom_directory(
"template": "git+https://github.com/fake/fake.git",
"directory": "my_directory",
}
starters_version = mock_determine_repo_dir.call_args[1].pop("checkout", None)

assert starters_version in [version, "main"]
assert kwargs.items() <= mock_determine_repo_dir.call_args[1].items()
assert kwargs.items() <= mock_cookiecutter.call_args[1].items()

Expand Down
Loading